Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSETS-44583 : Add Image modifier support in site editor page #2887

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

indra2gurjar
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (77dd95c) to head (76d2dd0).

Files with missing lines Patch % Lines
...s/internal/models/v3/NextGenDMImageURIBuilder.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2887      +/-   ##
============================================
- Coverage     87.15%   87.14%   -0.02%     
- Complexity     2692     2695       +3     
============================================
  Files           235      235              
  Lines          7188     7197       +9     
  Branches       1100     1103       +3     
============================================
+ Hits           6265     6272       +7     
- Misses          365      366       +1     
- Partials        558      559       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 18, 2024

@indra2gurjar indra2gurjar marked this pull request as ready for review December 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants