Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging -> main [Core-2.3.0] [Lifecycle-2.0.4] #517

Merged
merged 34 commits into from
Jul 26, 2023
Merged

staging -> main [Core-2.3.0] [Lifecycle-2.0.4] #517

merged 34 commits into from
Jul 26, 2023

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Jul 26, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

prudrabhat and others added 30 commits May 15, 2023 17:06
Do not overwrite appId with cachedAppId [MOB-19044]
setting the webview alpha to 99% does not cause any visual issues when testing on API 23 and above.
fix message placement and rounded corners on API 21/22
@praveek praveek requested a review from prudrabhat July 26, 2023 20:29
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #517 (b527dcb) into main (63163d7) will decrease coverage by 0.06%.
Report is 8 commits behind head on main.
The diff coverage is 73.81%.

@@             Coverage Diff              @@
##               main     #517      +/-   ##
============================================
- Coverage     86.72%   86.66%   -0.06%     
- Complexity     1504     1512       +8     
============================================
  Files           126      127       +1     
  Lines          5640     5669      +29     
  Branches        778      783       +5     
============================================
+ Hits           4891     4913      +22     
- Misses          420      425       +5     
- Partials        329      331       +2     
Flag Coverage Δ
functional-tests 24.01% <54.76%> (+0.12%) ⬆️
unit-tests 79.29% <73.81%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ting/mobile/internal/configuration/AppIdManager.kt 85.19% <ø> (ø)
...obe/marketing/mobile/services/DeviceInforming.java 100.00% <ø> (ø)
...marketing/mobile/lifecycle/LifecycleConstants.java 100.00% <ø> (ø)
...one/java/com/adobe/marketing/mobile/Lifecycle.java 100.00% <ø> (ø)
...e/internal/configuration/ConfigurationExtension.kt 81.73% <37.50%> (-1.77%) ⬇️
...ting/mobile/lifecycle/LifecycleMetricsBuilder.java 93.29% <66.67%> (-0.50%) ⬇️
...ting/mobile/lifecycle/XDMLifecycleApplication.java 78.95% <66.67%> (-2.30%) ⬇️
...ting/mobile/lifecycle/XDMLifecycleEnvironment.java 84.38% <85.71%> (-2.11%) ⬇️
.../adobe/marketing/mobile/lifecycle/XDMLanguage.java 91.67% <91.67%> (ø)
...ng/mobile/lifecycle/LifecycleV2MetricsBuilder.java 96.63% <100.00%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes

@praveek praveek merged commit 8195cbb into main Jul 26, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants