staging -> main (Core 3.0.1/ Lifecycle 3.0.1/ Identity 3.0.1) #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also replace deprecated test method.
Update SetExtensions.kt
Update LaunchRuleTransformer.kt
Fix event history logs
Currently, presentation delegate notifies only the url's opened by the UriService which is a regression from 2.x. Change the logic to make UiService handle both uri's and url's if the event listener is unable to handle them. Further, notify PresentationDelegate of all uri's opened as part of the interaction.
Currently AEPUIService creates a coroutine scope for every presentable to avoid one workflow distuption cancelling another. Instead we can use a combination of SupervisorJob and a Coroutine execption handler to use the same coroutine scope for all operations on main thread by UIService, while ensuring that the disjoint interactions do not interfere with each other.
Currently, screen shize related calculations are done once and remembered on recompositions. This works well when adapting to the new size when orientation of the device is changed. However, when the activity hosting the composable restricts configuration changes, the remembered value is not recomputed preventing the presentables from adapting to the new screen size. As a solution, do not remember the size related calculation. Always calculate them on composition.
Fix InAppMessage Scrolling
…ation Notify PresentationDelegate on all webview uri's
Always recompute screen size related calculations
… which triggers Analytics event.
Update MapExtensions.kt
Use a supervisor job and exception hander in UIService
…rivacy opt-out events.
Identity don't dispatch Analytics push event on privacy change
Update versions [Core-3.0.1] [Identity-3.0.1] [Lifecycle-3.0.1]
dev -> staging (Core 3.0.1/ Lifecycle 3.0.1/ Identity 3.0.1)
praveek
approved these changes
May 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
============================================
+ Coverage 81.42% 81.55% +0.13%
- Complexity 2123 2133 +10
============================================
Files 191 191
Lines 8913 8904 -9
Branches 1114 1111 -3
============================================
+ Hits 7257 7261 +4
+ Misses 1102 1089 -13
Partials 554 554
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.