-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staging -> main (core-v3.2.0) #717
Conversation
- rename DelegateGateNotMet` to `SuppressedByAppDeveloper`. - update conflict and suppressed by app developer error reasons to match the ones in-use in the iOS core
add `SuppressedByAppDeveloper` to `PresentationError` interface
add new error codes for AdobeError
Update versions [Core-3.2.0]
the coroutine children cancellation was causing all other coroutines other than the first to be cancelled early. this led to some race condition like behavior when determining if a presentable conflict had occurred. removing the children cancellation should have no effect on the event handling done in the `DefaultInAppMessageEventHandler`.
remove cancellation of coroutine children
dev -> staging (core-v3.2.0)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
=============================================
- Coverage 81.68% 69.27% -12.41%
+ Complexity 2152 1951 -201
=============================================
Files 192 192
Lines 8975 8981 +6
Branches 1125 1125
=============================================
- Hits 7331 6221 -1110
- Misses 1086 2293 +1207
+ Partials 558 467 -91
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AEPError
.SuppressedByAppDeveloper
constant to indicate that the in-app message was not displayed because it was rejected by the app developer via thePresentationDelegate
.