-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging to main for v3.0.0 release #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code of Conduct, Copyright and License files
PR templates, Contribution guidelines and GH action release scripts
Setup NotificationBuilder Project with UnitTest
CircleCI setup and testApp
- caller extensions need to handle this exception
setup repo with latest push template code
- Added a PushTemplateIntentConstants class which exposes the Intent actions and keys KVP. Other internal KVP remain in PushTemplateConstants. - Fix log tags to match the updated class names - Add support for dark mode. Dark mode is supported on API29+ only and any custom color modifications made to the push payload will override the dark/light mode colors. The following keys will overwrite the dark/light settings: "adb_clr_body" / body text color, "adb_clr_title" / title text color, "adb_clr_bg" / notification background color, and "adb_clr_icon" / small icon color
* setup test class for ZeroBezelNotificationBuilder * added test cases for ZeroBezelNotificationBuilder * added test cases to verify notifcation data * code clean up
- also make bitmap mockk relaxed in ZeroBezelNotificationBuilderTest
* MOB-21194: Add unit tests for ProductRatingNotificationBuilder * Address PR comments * address PR comments
* Added boilerplate class for MultiiconBuilderClass * Added carousel push template class * Removed wrong file added * Spotless apply
…ngIntentUtils unit tests (#44) * move remind later handling to different public class * NotificationCompatBuilderExtensions tests * improve readability * unmockAll in teardown for each test * RemoteViewsExtensionsTest tests * PendingIntentUtils tests * code review comments * code review comments 2 * assert import improvements
Timer notification builder unit tests
Add public Notification builder unit tests
* move remind later handling to different public class * NotificationCompatBuilderExtensions tests * improve readability * unmockAll in teardown for each test * RemoteViewsExtensionsTest tests * PendingIntentUtils tests * code review comments * code review comments 2 * assert import improvements * Change Multi-icon close button action type so it does not open app
Some UI Fixes in template.
Dev to Staging for v.3.0.0 release
Add extras for notification close intent
spoorthipujariadobe
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: