Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to main for v3.0.0 release #56

Merged
merged 194 commits into from
Jun 21, 2024
Merged

Staging to main for v3.0.0 release #56

merged 194 commits into from
Jun 21, 2024

Conversation

rymorale
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PravinPK and others added 30 commits May 15, 2024 10:32
Code of Conduct, Copyright and License files
PR templates, Contribution guidelines and GH action release scripts
Setup NotificationBuilder Project with UnitTest
CircleCI setup and testApp
- caller extensions need to handle this exception
setup repo with latest push template code
- Added a PushTemplateIntentConstants class which exposes the Intent actions and keys KVP. Other internal KVP remain in PushTemplateConstants.
-  Fix log tags to match the updated class names
- Add support for dark mode. Dark mode is supported on API29+ only and any custom color modifications made to the push payload will override the dark/light mode colors. The following keys will overwrite the dark/light settings:
"adb_clr_body" / body text color, "adb_clr_title" / title text color, "adb_clr_bg" / notification background color, and "adb_clr_icon" / small icon color
PratthamArora and others added 24 commits June 20, 2024 12:26
* setup test class for ZeroBezelNotificationBuilder

* added test cases for ZeroBezelNotificationBuilder

* added test cases to verify notifcation data

* code clean up
- also make bitmap mockk relaxed in ZeroBezelNotificationBuilderTest
* MOB-21194: Add unit tests for ProductRatingNotificationBuilder

* Address PR comments

* address PR comments
* Added boilerplate class for MultiiconBuilderClass

* Added carousel push template class

* Removed wrong file added

* Spotless apply
…ngIntentUtils unit tests (#44)

* move remind later handling to different public class

* NotificationCompatBuilderExtensions tests

* improve readability

* unmockAll in teardown for each test

* RemoteViewsExtensionsTest tests

* PendingIntentUtils tests

* code review comments

* code review comments 2

* assert import improvements
Timer notification builder unit tests
Add public Notification builder unit tests
* move remind later handling to different public class

* NotificationCompatBuilderExtensions tests

* improve readability

* unmockAll in teardown for each test

* RemoteViewsExtensionsTest tests

* PendingIntentUtils tests

* code review comments

* code review comments 2

* assert import improvements

* Change Multi-icon close button action type so it does not open app
Dev to Staging for v.3.0.0 release
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 91.21115% with 164 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9346f13). Learn more about missing BASE report.

Files Patch % Lines
...ficationbuilder/internal/PushTemplateImageUtils.kt 68.49% 34 Missing and 12 partials ⚠️
...rnal/builders/ManualCarouselNotificationBuilder.kt 85.92% 19 Missing and 10 partials ⚠️
...er/internal/templates/ProductRatingPushTemplate.kt 58.18% 19 Missing and 4 partials ⚠️
.../mobile/notificationbuilder/NotificationBuilder.kt 88.31% 8 Missing and 1 partial ⚠️
...uilder/internal/templates/MultiIconPushTemplate.kt 88.88% 0 Missing and 7 partials ⚠️
...r/internal/templates/ProductCatalogPushTemplate.kt 87.93% 6 Missing and 1 partial ⚠️
...ionbuilder/internal/templates/TimerPushTemplate.kt 82.05% 5 Missing and 2 partials ⚠️
.../internal/builders/MultiIconNotificationBuilder.kt 90.90% 1 Missing and 5 partials ⚠️
...rnal/builders/ProductCatalogNotificationBuilder.kt 95.77% 5 Missing and 1 partial ⚠️
...builder/internal/templates/CarouselPushTemplate.kt 85.36% 3 Missing and 3 partials ⚠️
... and 9 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage        ?   91.21%           
  Complexity      ?      282           
=======================================
  Files           ?       38           
  Lines           ?     1866           
  Branches        ?      173           
=======================================
  Hits            ?     1702           
  Misses          ?      101           
  Partials        ?       63           
Flag Coverage Δ
unit-tests 91.21% <91.21%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rymorale rymorale merged commit c066416 into main Jun 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants