Skip to content

Commit

Permalink
[dev 4.0.1 -> staging] Add namespace support for Android (#107)
Browse files Browse the repository at this point in the history
* Gradle 8.2 support (#88)

* Add conditional namespace to support gradle 8

* Use git as pub resource

* Revert "Use git as pub resource"

This reverts commit 027911d.

* fix

* fix

* fix

* Revert "fix"

This reverts commit 2a5a804.

* Revert "fix"

This reverts commit fbee65b.

* Revert "fix"

This reverts commit 746c0ca.

* Revert "Revert "Use git as pub resource""

This reverts commit 4b7485e.

* Revert "Use git as pub resource"

This reverts commit 027911d.

* Update Flutter version for the plugins, update sample app gradle files and Update issue_template (#106)

* bump the major version to 4.0.0 (to include Android SDK 3.0.0 and iOS SDK 5.0.0)

* specify the ios version

* update CI to use Xcode 15.0.1

* fix CI syntax issue

* draft

* cleanup

* update API doc

* address review comments

* address a review comment

* correct timeout accuracy

* Update FlutterAEPCorePlugin.m

* feat: ⬆️ messaging api changes

* Update EdgeBridge sample app and readme

Update EdgeBridge sample app and readme

* refactor: ♻️ rename edge event type for messaging

* chore: reenable messaging

* fix: 🐛 fixes for messaging

* disable unit tests

* docs: 📝 remove beta language from messaging docs

* Update README for Privacy Manifest changes (#100)

* update main README to show information about "Privacy Manifest"

* fix: 🐛 fix oncontentloaded to be android only

* Update Flutter version for the plugins, update sample app gradle files and update issue_template

Update Flutter version for the plugins
Update sample app gradle files
Update issue_template

---------

Co-authored-by: yansong <[email protected]>
Co-authored-by: dsoffiantini <[email protected]>

* update ci java-version (#108)

update ci java-version

* remove and gitignore pubspec.lock in the plugins (#109)

remove and gitignore pubspec.lock in the plugins

* Update GitHub issue (#110)

* update issue template description

update issue template description

* update bug_report.yml

update bug_report.yml

* Update android project gradle version (#111)

Update android project gradle version

* migration doc update (#112)

migration doc update

---------

Co-authored-by: Egon Meijers <[email protected]>
Co-authored-by: yansong <[email protected]>
Co-authored-by: dsoffiantini <[email protected]>
  • Loading branch information
4 people authored Apr 23, 2024
1 parent 4547b79 commit e0d36e8
Show file tree
Hide file tree
Showing 48 changed files with 453 additions and 1,514 deletions.
52 changes: 52 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Contributing

Thanks for choosing to contribute!

The following are a set of guidelines to follow when contributing to this project.

## Code Of Conduct

This project adheres to the Adobe [code of conduct](../CODE_OF_CONDUCT.md). By participating,
you are expected to uphold this code. Please report unacceptable behavior to
[[email protected]](mailto:[email protected]).

## Have A Question?

Start by filing an issue. The existing committers on this project work to reach
consensus around project direction and issue solutions within issue threads
(when appropriate).

## Contributor License Agreement

All third-party contributions to this project must be accompanied by a signed contributor
license agreement. This gives Adobe permission to redistribute your contributions
as part of the project. [Sign our CLA](http://opensource.adobe.com/cla.html). You
only need to submit an Adobe CLA one time, so if you have submitted one previously,
you are good to go!

## Code Reviews

All submissions should come in the form of pull requests and need to be reviewed
by project committers. Read [GitHub's pull request documentation](https://help.github.com/articles/about-pull-requests/)
for more information on sending pull requests.

Lastly, please follow the [pull request template](PULL_REQUEST_TEMPLATE.md) when
submitting a pull request!

## Style Guide

Code cleanliness and consistency is important. Please review and follow our code
[Style Guide](../Documentation/Contributing/StyleGuide.md) when contributing.

## From Contributor To Committer

We love contributions from our community! If you'd like to go a step beyond contributor
and become a committer with full write access and a say in the project, you must
be invited to the project. The existing committers employ an internal nomination
process that must reach lazy consensus (silence is approval) before invitations
are issued. If you feel you are qualified and want to get more deeply involved,
feel free to reach out to existing committers to have a conversation about that.

## Security Issues

Security issues shouldn't be reported on this issue tracker. Instead, [file an issue to our security experts](https://helpx.adobe.com/security/alertus.html)
24 changes: 8 additions & 16 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
<!--- STOP! Before you open an issue please search this repository's issues to see if it has already been reported. This helps reduce duplicate issues from being created. -->
<!--- SECURITY DISCLOSURE: If this is a security disclosure please follow the guidelines in CONTRIBUTING.md. This helps keep folks from accidentally releasing vulnerabilities before the maintainers get a chance to fix the issue. -->

### Expected Behaviour

### Actual Behaviour

### Reproduce Scenario (including but not limited to)

#### Steps to Reproduce

#### Platform and Version

#### Sample Code that illustrates the problem

#### Logs taken while reproducing problem
---
name: Blank issue
labels: task
---
## Prerequisites
<!--- Go through the items below before logging an issue -->
- [ ] I have searched in this repository's issues to see if it has already been reported.
- [ ] This is not a Security Disclosure, otherwise please follow the guidelines in [Security Policy](https://github.com/adobe/aepsdk-analytics-android/security/policy).
77 changes: 77 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
name: Bug report
description: Create a bug report to help us improve. Use this template if you encountered an issue while integrating with or implementing the APIs of this SDK.
labels: [bug, triage-required]

body:
- type: checkboxes
attributes:
label: Prerequisites
description: Please check the following items before logging a new bug report.
options:
- label: This is not a Security Disclosure, otherwise please follow the guidelines in [Security Policy](https://github.com/adobe/aepsdk_flutter/security/policy).
required: true
- label: I have searched in this repository's issues to see if it has already been reported.
required: true
- label: I have updated to the latest released version of the SDK and the issue still persists.
required: true

- type: textarea
attributes:
label: Bug summary
description: Please provide a summary of the bug you are reporting.
validations:
required: true

- type: textarea
attributes:
label: Environment
description: |
Please provide the Platform, OS version, SDK version(s) used, IDE version, and any other specific settings that could help us narrow down the problem.
Run `flutter doctor` and paste the output here.
Example:
[✓] MOBILE SDK VERSION: [email protected], [email protected]
[✓] Flutter (Channel stable, 3.19.6, on macOS 14.2.1 darwin-arm64)
• Flutter version 3.19.6 on channel stable at /development/flutter
• Dart version 3.3.4
• DevTools version 2.31.1
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
• CocoaPods version 1.14.3
validations:
required: true

- type: textarea
attributes:
label: Steps to reproduce
description: Steps to reproduce the behavior consistently.
placeholder: |
1. ...
2. ...
3. ...
validations:
required: false

- type: textarea
attributes:
label: Current behavior
description: A concise description of what you are experiencing.
validations:
required: false

- type: textarea
attributes:
label: Expected behavior
description: A concise description of what you expected to happen.
validations:
required: false

- type: textarea
attributes:
label: Anything else?
description: |
Here you can include sample code that illustrates the problem, logs taken while reproducing the problem, or anything that can give us more context about the issue you are encountering.
Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in.
validations:
required: false
43 changes: 43 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Feature request
description: Suggest an idea for this project.
labels: [feature-request, triage-required]

body:
- type: checkboxes
attributes:
label: Prerequisites
description: Please check the following items before logging a new feature request.
options:
- label: This is not a Security Disclosure, otherwise please follow the guidelines in [Security Policy](https://github.com/adobe/aepsdk-flutter/security/policy).
required: true
- label: I have searched in this repository's issues to see if it has already been reported.
required: true

- type: textarea
id: description
attributes:
label: Feature request summary
description: Please provide a summary of the feature.
validations:
required: true

- type: textarea
attributes:
label: Current behavior
description: A concise description of what you are experiencing.
validations:
required: false

- type: textarea
attributes:
label: Expected behavior
description: A concise description of what you expected to happen.
validations:
required: false

- type: textarea
attributes:
label: Additional implementation details or code snippets
description: Provide additional information about this request, implementation details or code snippets.
validations:
required: false
24 changes: 24 additions & 0 deletions .github/ISSUE_TEMPLATE/project_epic.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Project epic
description: Create an internal epic that represents the top level parent of multiple tasks.
labels: [epic]

body:
- type: textarea
id: description
attributes:
label: Epic description
description: Please provide a detailed description for this epic.
validations:
required: true

- type: textarea
id: tasks
attributes:
label: Tasks
description: |
Provide a high-level definition of done for this epic as a list of tasks that need to be completed.
Tip: List out the task links if they already exist or list them out as text with a descriptive title so they can be easily converted to task items.
placeholder: |
- [ ] your task link here
validations:
required: false
17 changes: 17 additions & 0 deletions .github/ISSUE_TEMPLATE/project_task.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Project task
description: Create an internal task that can be completed as a standalone code change or is part of an epic.
labels: [task]
body:
- type: textarea
attributes:
label: Task description
description: Please provide a summary or the "what" of the task logged.
validations:
required: true

- type: textarea
attributes:
label: Additional implementation details or code snippet(s)
description: Provide additional information about this task, implementation details or code snippets.
validations:
required: false
16 changes: 16 additions & 0 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#
# Copyright 2024 Adobe. All rights reserved.
# This file is licensed to you under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License. You may obtain a copy
# of the License at http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under
# the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
# OF ANY KIND, either express or implied. See the License for the specific language
# governing permissions and limitations under the License.
#

template: |
## What’s Changed
$CHANGES
33 changes: 17 additions & 16 deletions .github/workflows/dart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./example
Expand All @@ -48,10 +48,10 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./example
Expand All @@ -73,10 +73,10 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./plugins/flutter_aepcore
Expand All @@ -94,10 +94,10 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./plugins/flutter_aepassurance
Expand All @@ -115,10 +115,10 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./plugins/flutter_aepedge
Expand All @@ -136,10 +136,10 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./plugins/flutter_aepedgeconsent
Expand All @@ -157,10 +157,10 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./plugins/flutter_aepedgeidentity
Expand All @@ -177,10 +177,10 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: "12.x"
java-version: "17.x"
- uses: subosito/flutter-action@v2
with:
flutter-version: "2.x"
flutter-version: "3.x"

- name: Install dependencies
working-directory: ./plugins/flutter_aepuserprofile
Expand All @@ -189,3 +189,4 @@ jobs:
- name: Unit test
working-directory: ./plugins/flutter_aepuserprofile
run: flutter test

5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,7 @@ example/android/GeneratedPluginRegistrant.java
**/ios/Icon?
**/ios/.tags*
**/ios/Flutter/Generated.xcconfig
**/ios/flutter_export_environment.sh
**/ios/flutter_export_environment.sh

# podspec.lock
plugins/**/pubspec.lock
4 changes: 2 additions & 2 deletions docs/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Update your `pubspec.yml` file to point to the new plugin as so:

dependencies:
- flutter_acpcore: ^2.0.0
+ flutter_aepcore: ^3.0.0
+ flutter_aepcore: ^4.0.0

...
```
Expand Down Expand Up @@ -344,7 +344,7 @@ final Event event = Event({
"eventData": {"eventDataKey": "eventDataValue"}
});
try {
result = await MobileCore.dispatchEventWithResponseCallback(event);
result = await MobileCore.dispatchEventWithResponseCallback(event, 1000);
} on PlatformException catch (e) {
log("Failed to dispatch event '${e.message}''");
}
Expand Down
Loading

0 comments on commit e0d36e8

Please sign in to comment.