Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datastream override feature to Edge plugin. #120

Merged
merged 21 commits into from
May 10, 2024

Conversation

cacheung
Copy link
Contributor

@cacheung cacheung commented May 1, 2024

Add datastream override feature to Edge plugin.

  • Update dart code.
    Add wrapper support for 'datastreamIdOverride' and 'datastreamConfigOverride';
    There are two methods to support the usage.
    Using Dictionary
    final ExperienceEvent experienceEvent = ExperienceEvent({
    "xdmData": xdmData,
    "data": data,
    "datastreamIdOverride": "sampleDatastreamID"
    "datastreamConfigOverride": configOverrides
    })

Using Constructor
final ExperienceEvent experienceEvent =
ExperienceEvent.createEventWithOverrides(xdmData, data, "datastreamId", configOverrides);

We keep the previous supported usage for datasetId for backward compatibility.

  • Update Android data bridge
  • Update iOS data bridge
  • Update Readme file
  • Update sample app
EdgeView

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Update Edge workflow info for track APIs doc and migration doc.
[Release 4.0.1] Staging --> Main
Update readme with the supported platforms info
Update readme with the supported platforms info
Add Datastream override feature to Edge plugin.
remove extra line
Fix the typo for the method name in sample app
Fix typo in sample app
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
Update experienceEvent dart code to use two classes
Update readme and unit test
Update test app
Update typo in sample app
fix typo in readme
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
update with review comments
update with review comments
@cacheung
Copy link
Contributor Author

cacheung commented May 9, 2024

@addb Thanks for the reviewing, I updated with your review comments.

example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
example/lib/edge.dart Outdated Show resolved Hide resolved
fix configOverrides format, and other review comments
fix text format
Update Readme File
add space after a comma
Update to _datasetIdentifierKey name
@cacheung cacheung merged commit 2f99735 into adobe:staging May 10, 2024
10 checks passed
@cacheung cacheung deleted the edgeOverRide branch May 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants