Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear tokens on logout #33

Merged
merged 8 commits into from
Jun 2, 2020
Merged

fix: clear tokens on logout #33

merged 8 commits into from
Jun 2, 2020

Conversation

rajarju
Copy link
Contributor

@rajarju rajarju commented May 19, 2020

aio logout was not clearing refresh_token

Description

  • show confirmation messages on logout
  • show confirmation message if already logged out

Related Issue

Fixes: #32

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- show confirmation messages on logout
- show confirmation message if already logged out
src/commands/auth/logout.js Outdated Show resolved Hide resolved
Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing, because of missing tests (or tests not changed).

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          115       120    +5     
  Branches        24        25    +1     
=========================================
+ Hits           115       120    +5     
Impacted Files Coverage Δ
src/commands/auth/logout.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e47296e...5062c76. Read the comment docs.

@rajarju
Copy link
Contributor Author

rajarju commented Jun 1, 2020

@shazron Please review the changes

@rajarju rajarju requested a review from shazron June 1, 2020 07:42
@shazron shazron merged commit 9c45c44 into master Jun 2, 2020
@shazron shazron deleted the rajarju/fix-logout-token branch June 2, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio logout does not log the user out (access token still stored in local)
2 participants