Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tech summit] Use new aio app structure for example photoshop worker #68

Merged
merged 9 commits into from
Mar 9, 2022
Merged

[tech summit] Use new aio app structure for example photoshop worker #68

merged 9 commits into from
Mar 9, 2022

Conversation

jdelbick
Copy link
Contributor

@jdelbick jdelbick commented Mar 8, 2022

Description

Related Issue

I need this for the demo for tech summit: https://jira.corp.adobe.com/browse/ASSETS-7472

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jdelbick jdelbick requested review from tmathern and pheenomenon March 8, 2022 00:26
tmathern
tmathern requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be careful with the used node version - readme mentions 10 and 12, you use 14. After fixing that, LGTM.

ga-aio-projects/worker-cc-photoshop/README.md Outdated Show resolved Hide resolved
ga-aio-projects/worker-cc-photoshop/README.md Outdated Show resolved Hide resolved
ga-aio-projects/worker-cc-photoshop/README.md Outdated Show resolved Hide resolved
ga-aio-projects/worker-cc-photoshop/README.md Outdated Show resolved Hide resolved
ga-aio-projects/worker-cc-photoshop/README.md Outdated Show resolved Hide resolved
ga-aio-projects/worker-cc-photoshop/README.md Outdated Show resolved Hide resolved
...jects/worker-cc-photoshop/src/dx-asset-compute-worker-1/actions/worker-cc-photoshop/index.js Outdated Show resolved Hide resolved
ga-aio-projects/worker-cc-photoshop/src/dx-asset-compute-worker-1/ext.config.yaml Show resolved Hide resolved
@jdelbick
Copy link
Contributor Author

jdelbick commented Mar 8, 2022

@tmathern thanks I will make the changes. I had just copied the README from the old photoshop example worker, hence the old node versions mentioned

jdelbick and others added 7 commits March 8, 2022 14:03
@jdelbick jdelbick requested a review from tmathern March 8, 2022 22:11
@jdelbick jdelbick merged commit 0612049 into master Mar 9, 2022
@jdelbick jdelbick deleted the photoshop-action-new-aio-structure branch March 9, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmathern tmathern tmathern approved these changes

@pheenomenon pheenomenon Awaiting requested review from pheenomenon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdelbick @tmathern