Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include assertions #106

Merged
merged 6 commits into from
May 3, 2024
Merged

include assertions #106

merged 6 commits into from
May 3, 2024

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented May 3, 2024

This PR is for the implementation of the Assertions defined in issue #3

Resolves #3

Description

A user can include a set of assertions in the payload to the bridgeService. This allows you to check the results, and to delegate a call to a third party for exeutions.

The Assertions is currently of two types:

  • Result Based
  • Duration Based

Related Issue

#3

Motivation and Context

This feature allows users to define expectation for an execution.

How Has This Been Tested?

  • unit tests
  • integration tests
  • manual runs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@baubakg baubakg linked an issue May 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (fd992a5) to head (b9f968d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #106      +/-   ##
============================================
+ Coverage     89.43%   90.36%   +0.92%     
- Complexity      219      239      +20     
============================================
  Files            23       24       +1     
  Lines           587      633      +46     
  Branches         57       57              
============================================
+ Hits            525      572      +47     
  Misses           47       47              
+ Partials         15       14       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented May 3, 2024

@baubakg baubakg merged commit 2d5eeb6 into main May 3, 2024
10 checks passed
@baubakg baubakg deleted the 3-include-assertions branch May 3, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include an assert method
1 participant