Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #180 fixing expansion of header values in the environment variable #182

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Oct 7, 2024

Description

Fixing issue #180 where we did not expand environment variables with header values.

Related Issue

Fixes #180

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@baubakg baubakg linked an issue Oct 7, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Oct 7, 2024

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (a7f7982) to head (0c1b33b).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #182      +/-   ##
============================================
+ Coverage     92.57%   92.61%   +0.03%     
- Complexity      291      292       +1     
============================================
  Files            26       26              
  Lines           795      799       +4     
  Branches         69       69              
============================================
+ Hits            736      740       +4     
  Misses           46       46              
  Partials         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baubakg baubakg merged commit 236a01e into main Oct 7, 2024
10 checks passed
@baubakg baubakg deleted the 180-support-for-environment-variables-and-secrets branch October 7, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for variable expansion of headers in environment variables
1 participant