feat: support esbuild as alternative bundler
#760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will add tests for this bundler, works as follows: |
dominique-pfister
changed the title
esbuild for bundlingesbuild as alternative bundler
Comment on lines
+570
to
+572
| if (!bundler) { | ||
| return this; | ||
| } |
There was a problem hiding this comment.
leave webpack as default bundler
Comment on lines
+57
to
+59
| 'import { createRequire } from "module";', | ||
| 'const require = createRequire(import.meta.url);', | ||
| '', |
There was a problem hiding this comment.
"required" for cjs imports
|
This PR will trigger a minor release when merged. |
Comment on lines
+77
to
+80
| // use @adobe/helix-universal in the calling service, not ours | ||
| build.onResolve( | ||
| { filter: /^@adobe\/helix-universal$/ }, | ||
| (args) => ({ path: path.resolve(cfg.cwd, 'node_modules', args.path, 'src', 'index.js') }), |
There was a problem hiding this comment.
subtle point: when the bundler tries to resolve @adobe/helix-universal, and it adds its own version, it will also resolve other dependencies there (e.g. @adobe/fetch), which is unexpected.
adobe-bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
# [12.4.0](v12.3.11...v12.4.0) (2024-12-06) ### Features * support `esbuild` as alternative bundler ([#760](#760)) ([fc9c85a](fc9c85a))
|
🎉 This PR is included in version 12.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently adds
esbuildas dependency, not sure whether there's another mechanism to not inflatehelix-deploys dependency list.