Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDS] pageviews min cwv count threshold #1013

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dbrrt
Copy link
Collaborator

@dbrrt dbrrt commented Dec 5, 2023

This introduces a new query for EDS alerting requirements. It aims to return urls, with their respective pageviews and p75 cwv for a given url pattern (e.g.: www.adobe.com/express), having a minimal count of cwv events matching the cwv_type passed as a parameter.

This can be helpful to know which URLs with a cwv count (for the cwv_type passed as parameter, e.g.: LCP) greater than the threshold passed as parameter.

Related Issues

https://cq-dev.slack.com/archives/C05A45JBP9N/p1700727862022749

Some adjustements from the initial thread have been made

  • cwv_type added as a parameter to retrieve records with cwv min count (cwv type specific)
  • cwv_count_threshold minimum count threshold to expose results
  • avg_daily_pageviews_factor parameter, aiming to reduce pageviews calculation issues related to sampling

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

@dbrrt dbrrt marked this pull request as draft December 5, 2023 17:53
Copy link

github-actions bot commented Dec 5, 2023

This PR will trigger a patch release when merged.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b732ef1) 100.00% compared to head (b9f7fc4) 100.00%.
Report is 3 commits behind head on main.

❗ Current head b9f7fc4 differs from pull request most recent head 4e69e81. Consider uploading reports for the commit 4e69e81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1013   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          710       710           
=========================================
  Hits           710       710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants