fix: IndexConfig should not allow broken config

BREAKING CHANGE: some indexing configurations will no longer be accepted

packages/helix-shared-config/src/IndexConfig.js

@@ -193,4 +193,17 @@ export class IndexConfig extends SchemaDerivedConfig {
     this._version = this._cfg.version;
     return this;
   }
+
+  /**
+   * Validates the loaded configuration and coerces types and sets defaulst
+   */
+  async validate() {
+    await super.validate();
+
+    if (this._document?.errors?.length) {
+      const detail = this._document.errors.map(({ message }) => (message)).join('\n');
+      throw new Error(`Invalid index configuration:
+        ${detail}`);
+    }
+  }
 }

packages/helix-shared-config/test/indexconfigs.test.js → packages/helix-shared-config/test/IndexConfig.test.js

@@ -72,18 +72,18 @@ describe('Index Config Loading', () => {
     assert.deepEqual(actual, expected);
   });
 
-  it('Does not trip over broken config', async () => {
+  it('Trips over broken config', async () => {
     const cfg = new IndexConfig()
       .withConfigPath(path.resolve(SPEC_ROOT, 'broken.yaml'));
 
-    await cfg.init();
-
-    assert.strictEqual(cfg.getQuery('foo', 'bar'), undefined);
+    await assert.rejects(async () => cfg.init(), /Implicit map keys need to be followed by map value/);
+  });
 
-    const actual = cfg.toJSON();
-    const expected = JSON.parse(await fs.readFile(path.resolve(SPEC_ROOT, 'broken.json'), 'utf-8'));
+  it('Trips over config with duplicate property', async () => {
+    const cfg = new IndexConfig()
+      .withConfigPath(path.resolve(SPEC_ROOT, 'duplicate.yaml'));
 
-    assert.deepEqual(actual, expected);
+    await assert.rejects(async () => cfg.init(), /Map keys must be unique at line 10, column 7/);
   });
 
   it('Does not trip over non-existing config', async () => {

packages/helix-shared-config/test/specs/queryconfigs/duplicate.yaml

@@ -0,0 +1,12 @@
+version: 1
+
+indices:
+  blog-posts:
+    properties:
+      author:
+        select: main > div:nth-of-type(3) > p:nth-of-type(1)
+        value: |
+          ${match('by (.*)')}
+      author:
+        select: other
+        value: ${match('by (.*)')}