Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using esm modules via dynamic imports #101

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pheenomenon
Copy link

wip branch to convert cjs to esm, using dynamic imports.
Observations:

  1. Eslint failures:
    • error Parsing error: Unexpected token import
      • possible solution is to use "parser": "babel-eslint" in .eslintrc.js
  2. nocks in tests returns empty response.statusText

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pheenomenon pheenomenon changed the title dynamic imports using esm modules via dynamic imports Jun 4, 2022
@adobe-bot
Copy link

🚨 Sizewatcher had a measurement error:

   🎉 git -75.2% (656 kB => 163 kB)

   🚨 node_modules measurement error: Command failed: npm ci
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm ERR! code UNABLE_TO_GET_ISSUER_CERT_LOCALLY
npm ERR! errno UNABLE_TO_GET_ISSUER_CERT_LOCALLY
npm ERR! request to https://artifactory.corp.adobe.com/artifactory/api/npm/npm-adobe-release/npm/-/npm-7.24.2.tgz failed, reason: unable to get local issuer certificate

npm ERR! A complete log of this run can be found in:
npm ERR! /home/runner/.npm/_logs/2022-06-04T23_29_33_372Z-debug-0.log

npm_package has no changes (11.5 kB)
Package contents:
📦  @adobe/[email protected]
=== Tarball Contents ===
850B .releaserc.json
3.2kB CODE_OF_CONDUCT.md
171B COPYRIGHT
11.3kB LICENSE
7.0kB README.md
555B index.d.ts
12.6kB index.js
1.1kB package.json
=== Tarball Details ===
name: @adobe/node-fetch-retry
version: 2.2.0
filename: @adobe/node-fetch-retry-2.2.0.tgz
package size: 11.5 kB
unpacked size: 36.9 kB
shasum: a62c1e4791071f9c07e9578cbde67f0976a2440f
integrity: sha512-4GaJKdVnHQnL9[...]Jv495BZPSWPQA==
total files: 8
Notes
  • PR branch: ASSETS-94-dynamic-imp @ 3c614c0
  • Base branch: master
  • Sizewatcher v1.2.1
  • Effective Configuration:
limits:
  fail: 100%
  warn: 30%
  ok: '-10%'
report:
  githubComment: true
  githubStatus: false
comparators: {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants