-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #86 - Pluggable Fetch #109
Open
klcodanr
wants to merge
2
commits into
master
Choose a base branch
from
feature/86-adobe-fetch-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -187,6 +187,7 @@ function shouldRetryOnHttpError(error) { | |
/** | ||
* @typedef {Object} Options options for fetch-retry | ||
* @property {Object} RetryOptions options for retry or false if want to disable retry | ||
* @property {Function} fetch the fetch implementation to use | ||
* ... other options for fetch call (method, headers, etc...) | ||
*/ | ||
/** | ||
|
@@ -209,13 +210,15 @@ module.exports = async function (url, options) { | |
|
||
let timeoutHandler; | ||
if (retryOptions.socketTimeout) { | ||
const controller = new AbortController(); | ||
const abortCon = options.AbortController || AbortController; | ||
const controller = new abortCon(); | ||
timeoutHandler = setTimeout(() => controller.abort(), retryOptions.socketTimeout); | ||
options.signal = controller.signal; | ||
} | ||
|
||
try { | ||
const response = await fetch(url, options); | ||
const fetchFn = options.fetch || fetch; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this recursively invokes In case the options may get wiped away between retries (maybe this is too unrealistic) |
||
const response = await fetchFn(url, options); | ||
|
||
if (await shouldRetry(retryOptions, null, response, waitTime)) { | ||
console.error(`Retrying in ${waitTime} milliseconds, attempt ${attempt} failed (status ${response.status}): ${response.statusText}`); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference between adobe/fetch's abort controller and ours?