Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node-fetch-v3 support #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solaris007
Copy link
Member

@solaris007 solaris007 commented Sep 1, 2021

Description

node-fetch v3 has been released. This PR serves for starting the discussion of updating node-fetch-retry to allow use of v3, which is ESM only. A full conversion of node-fetch-retry to ESM is not necessary when using async import.

Minimum node version required would be 12.20

https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md

Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Dependency update with code changes (no functional impact)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #54 (a2e27a4) into master (4161e43) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           68        67    -1     
=========================================
- Hits            68        67    -1     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4161e43...a2e27a4. Read the comment docs.

@jdelbick
Copy link
Contributor

jdelbick commented Sep 8, 2021

please fix the failing unit tests for node 10.16, 10.19 & 12.16

@alexkli alexkli added the contribution PR from an external contributor label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants