retry on all thrown errors by default

[jdelbick]

Fixes #88

Note: this is for v3 and thus goes into the version3 branch, not master.

Description

Requires #87 as a pre-requisite

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (version3@47ec289). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             version3      #90   +/-   ##
===========================================
  Coverage            ?   98.75%           
===========================================
  Files               ?        1           
  Lines               ?       80           
  Branches            ?        0           
===========================================
  Hits                ?       79           
  Misses              ?        1           
  Partials            ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ec289...aefaa43. Read the comment docs.

[jdelbick]

TODO: will be false once #87 is done

[alexkli]

@jdelbick I changed this PR to go into the new version3 branch.

[jdelbick]

@alexkli should I wait to merge this until #87 is fixed & merged to v3?

[alexkli]

I think this can be merged already. See my additional inline comment.

[adobe-bot]

🎉 Sizewatcher congratulates on the size improvement 📉:

   🎉 git -81.8% (740 kB => 134 kB)

✅ node_modules -1.7% (74.8 MB => 73.5 MB)

Largest production node modules:

┌──────────────────┬────────────┬───────┐
│ name             │ children   │ size  │
├──────────────────┼────────────┼───────┤
│ node-fetch       │ 0          │ 0.14M │
├──────────────────┼────────────┼───────┤
│ abort-controller │ 0          │ 0.07M │
├──────────────────┼────────────┼───────┤
│ 2 modules        │ 0 children │ 0.22M │
└──────────────────┴────────────┴───────┘

✅ npm_package -0.9% (11.4 kB => 11.3 kB)

Package contents:

📦  @adobe/[email protected]
=== Tarball Contents === 
850B   .releaserc.json   
3.2kB  CODE_OF_CONDUCT.md
171B   COPYRIGHT         
11.3kB LICENSE           
7.2kB  README.md         
555B   index.d.ts        
11.2kB index.js          
1.1kB  package.json      
=== Tarball Details === 
name:          @adobe/node-fetch-retry                 
version:       2.2.0                                   
filename:      @adobe/node-fetch-retry-2.2.0.tgz       
package size:  11.3 kB                                 
unpacked size: 35.7 kB                                 
shasum:        d0067f0714a0aa2a59ac358534903f232a57d8d2
integrity:     sha512-slsMHSH5tkwGB[...]oVdrOrugOhSAQ==
total files:   8

Notes

• PR branch: retry-on-all-errors-default @ 71b90d2
• Base branch: version3
• Sizewatcher v1.2.1
• Effective Configuration:

limits:
  fail: 100%
  warn: 30%
  ok: '-10%'
report:
  githubComment: true
  githubStatus: false
comparators: {}