-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 support #6437
Merged
Merged
React 19 support #6437
Changes from 9 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
df2b082
React 19 prep
snowystinger 8762eb5
Fix tests and lint, need to investigate the isReact 19 tests
snowystinger 484c66d
turn 19 tests back on
snowystinger e32b0c2
Check react version to avoid warning
snowystinger 15382bf
bump node version because 18.17 has a bug with pkg.json dependencies …
snowystinger 97c221e
Install 19 types
snowystinger 8e552d1
apply codemod
snowystinger da2b6eb
Apply fixes from TS and eps1lon PR
snowystinger f981fb3
Reset package json
snowystinger 4eba72a
Merge branch 'main' into react-19-prep
snowystinger 533533d
Merge branch 'main' into react-19-prep
snowystinger 489fdaa
Fix React 18 on 19's types
snowystinger 9f669fe
default to react 19 development to avoid duplicate packages being ins…
snowystinger af56ac7
fix a couple failures
snowystinger d9f8a2b
fix test
snowystinger 885bb0c
fix storybook 18
snowystinger bd3d13b
Fix extract examples
snowystinger bc0d291
install process
snowystinger 10457a1
actually fix test
snowystinger 0c65ce3
Revert using React 19 as the default
snowystinger 5489fe0
fix the listbox test once more
snowystinger 642fcfa
Workaround 19 install issue
snowystinger e26bae6
fix extract examples to work with 19 types
snowystinger a3f69f5
fix react dom import
snowystinger 221eea7
Fix types for all docs
snowystinger 49430f6
Merge branch 'main' into react-19-prep
snowystinger e9d4cb8
work around react 19 giving us an unintentional undefined
snowystinger f64e2ed
Merge branch 'react-19-prep' of github.com:adobe/react-spectrum into …
snowystinger 3710e8e
fix typescript
snowystinger fc11d33
disable branch verdaccio now that it's all passing
snowystinger 8db6f7d
Merge branch 'main' into react-19-prep
LFDanLu 7b4cc72
Review updates
snowystinger 7fd4732
Merge branch 'main' into react-19-prep
snowystinger 9284d9f
fix lint
snowystinger 14dd64d
Merge branch 'main' into react-19-prep
snowystinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should types for 19 always be installed?