-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add number type in value #6636
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Would you mind adding "./packages/@react-types/radio" to our tsconfig? Figured we might as well add it our TS Strictmode check if we're updating the types.
Lines 129 to 130 in 72151b3
"./packages/@react-types/progress", | |
"./packages/@react-types/searchfield", |
Also, would you be interested in handling the updates to support number in Checkbox/CheckboxGroup as well? It's okay if not. I'd be happy to get this in and follow-up later with the support for checkbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update
if (!state.selectedValue) { |
to
if (state.selectedValue == null) {
because the selectedValue could be 0 which would trigger this to set the last focused value to null
it looks like we're ok in useRadio
@snowystinger @yihuiliao thx! Corrections are complete. |
Closes
β Pull Request Checklist:
π Test Instructions:
π§’ Your Project: