-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom calendar support #7803
Open
ToyWalrus
wants to merge
20
commits into
adobe:main
Choose a base branch
from
ToyWalrus:custom-calendar-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the type checker
Finally learned how to run `make check-examples` myself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3270
Custom calendar support
This PR...
createCalendar
prop onCalendar
andRangeCalendar
to allow for a custom calendar implementationCalendar
interface with additional optional methods to implement:getWeeksInMonth()
getWeeksInMonth()
method in@internationalized/date/src/queries.ts
(Used when determining how many rows to display in a calendar for a given month)getCurrentMonth()
startOfMonth()
andendOfMonth()
methods in@internationalized/date/src/queries.ts
@internationalized/date/src/manipulation.ts
isSamePeriod()
isSameDay()
,isSameMonth()
, andisSameYear()
in@internationalized/date/src/queries.ts
(Used when determining whether to disable certain days because they're outside the current month. Added support for "day", "week", "month", and "year" for completeness)@react-spectrum/calendar/stories/Calendar.stories.tsx
that uses a custom 4-5-4 calendar implementation@react-spectrum/calendar/stories/RangeCalendar.stories.tsx
that uses the same 4-5-4 calendar implementationCalendar
andRangeCalendar
explaining how to create and use a custom calendar implementationThis change is backwards compatible and will not break any existing calendars.
✅ Pull Request Checklist:
📝 Test Instructions:
I added a custom 4-5-4 calendar implementation that gets used in the added stories and test cases, at
@internationalized/date/tests/customCalendarImpl.js
. (Side note: I don't know if there's a better place for this file to live, since I didn't see any sort of "test utils" files that were commonly shared) This calendar was originally added to the Typescript calendar stories file in this PR's commit history but was later moved to a JS file in the test folder to be shared from there.This custom calendar's correctness can be verified by using this link to a custom 4-5-4 calendar, or by comparing it to other such calendars found online.
🧢 Your Project:
Adobe, Analysis Workspace