fix: Add tree row label to expand/collapse button announcement #7840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
commented
Feb 27, 2025
Comment on lines
+49
to
+52
| let labelProps = useLabels({ | ||
| 'aria-label': isExpanded ? stringFormatter.format('collapse') : stringFormatter.format('expand'), | ||
| 'aria-labelledby': gridListAria.rowProps.id | ||
| }); |
There was a problem hiding this comment.
for some reason my ipad VO doesn't announce "expand" anymore, just the row label, digging
There was a problem hiding this comment.
Possibly unhelpful, but it's working on my iPhone
18.3.1
accessibility tree looks right in chrome inspector, and from looking in the dom, it looks fine as well
There was a problem hiding this comment.
thanks for testing in 18! I feel like we've run into this iOS 17 VO before but I couldn't find any prior documentation in our other collapsable/expandable components but will punt for now
snowystinger
previously approved these changes
Feb 27, 2025
snowystinger
approved these changes
Feb 28, 2025
devongovett
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: