Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: v3 TreeView border overlap #7873

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix: v3 TreeView border overlap #7873

merged 1 commit into from
Mar 6, 2025

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Mar 6, 2025 •
edited
Loading

Closes

original tried to fix a missing top border in c5851c8#comments but introduced an overlap between items resulting in too thick a border
image (12)

this pr fixes both issues

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Mar 6, 2025

Build successful! 🎉

@devongovett devongovett merged commit 2d7e441 into main Mar 6, 2025
32 checks passed
@devongovett devongovett deleted the fix-tree-border-overlap branch March 6, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snowystinger @rspbot @devongovett