-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: support selectionMode="replace" in grid collection test utils #8028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LFDanLu
wants to merge
25
commits into
main
Choose a base branch
from
highlight_selection_test_util_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a32b16e
attempt to get rid of jest calls in menu util
LFDanLu e326a35
update RSP testing docs to directly mention mocks that maybe needed
LFDanLu 9481673
bump versions of RTL to 16
LFDanLu f625818
use alternative to calling jest run timers in menu option selection
LFDanLu 69d289f
fixing types and properly testing long press
LFDanLu 366c1f8
fix lint
LFDanLu 5a502b8
Merge branch 'main' of github.com:adobe/react-spectrum into test_util…
LFDanLu 8f55260
revert to pre testing library bump for clean slate
LFDanLu 93cbb33
fix build and another submenu edge case
LFDanLu 5207639
fix react 16 bug
LFDanLu 14452d8
update return type of advanceTimer and docs copy
LFDanLu 8bd33c4
Initial support for tree highlight selection support
LFDanLu dd52a74
move some general fixes from selectionMode="replace" branch here
LFDanLu 5ef9f19
add highlight selection support to gridlist, listbox, and table
LFDanLu fc4b727
add test for deselection with modifier and add gridlist tests
LFDanLu 40d7b2f
Merge branch 'test_util_bug_fixes' of github.com:adobe/react-spectrum…
LFDanLu 972e5a2
fix build
LFDanLu 53763bd
add listbox test and fix logic for keyboard selection in utils
LFDanLu 96b4a85
add table util highlight selection tests and add proper keyboard navi…
LFDanLu 94b383c
Merge branch 'main' of github.com:adobe/react-spectrum into highlight…
LFDanLu d48a7c8
Merge branch 'main' of github.com:adobe/react-spectrum into highlight…
LFDanLu e046e74
remove dep on react-aria/utils
LFDanLu 2ba33fc
update yarn lock
LFDanLu 5e9ddb5
review comments
LFDanLu 772a5a5
update prop name for clarity
LFDanLu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.