-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Allow scroll events to be added on certain table components #8150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@yihuiliao I've no idea who/how to ping here but I'd love a approve or reject or a timeline if you are able. If the decision is not to support this kind of thing and instead e.g. only support long press when it is added as a real feature, we can plan around that. |
We've been a little busy with the latest release, hopefully we'll have a look at this in the near future. Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a chance to discuss as a team today. We're ok with the onScroll to start, we're not quite ready for onContextMenu at this point because it may interfere with our long press handling on touch. We'd like to think that one over more.
Thanks @snowystinger We've implemented it in our app and you are right - it conflicts on mobile. Our solution is that we disable drag and drop on mobile and add a mobile "edit mode" that shows the grid in drag and drop mode. I would be ok with only allowing attaching onContextMenu if there are no drag and drop hooks - maybe thats hard to communicate? but then alot of tables don't have drag and drop. I'll make the changes suggested in this PR and wait for any decision on context menu. |
ff69cf4
to
b472822
Compare
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
In the meantime, if you know the rules around conflicts with Drag and Drop/actions/etc and anything else, then you should be able to use context menus through the ref attached to any given element.
Thanks! We are currently patching react-aria-components as attaching event handlers using refs is a bit messy |
Closes #8040
Related (but not closing) #7987
✅ Pull Request Checklist:
📝 Test Instructions:
N/A
🧢 Your Project:
Saxo Bank