Skip to content

fix ColorSlider className #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

fix ColorSlider className #8190

merged 1 commit into from
May 5, 2025

Conversation

chirokas
Copy link
Contributor

@chirokas chirokas commented May 4, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

snowystinger
snowystinger approved these changes May 4, 2025
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this matches our other v3 components such as ColorArea
https://github.com/adobe/react-spectrum/blob/main/packages/%40react-spectrum/color/src/ColorArea.tsx#L61

@reidbarber reidbarber added this pull request to the merge queue May 5, 2025
Merged via the queue into adobe:main with commit 542e48d May 5, 2025
29 of 30 checks passed
@chirokas chirokas deleted the colorslider-classname branch May 6, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirokas @snowystinger @reidbarber