fix: prevent combobox from closing when navigating through items with keyboard #8301
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8298
Seems like the order that
scrollIntoView
andscrolIntoViewport
matters so wrap it all in a raf✅ Pull Request Checklist:
📝 Test Instructions:
I can't seem to actually reproduce in our storybook but I can within our docs.
Would be good to test to make sure that V3 Picker still scroll into view with this change. You can test with the "long item text" story
🧢 Your Project: