fix flip behavior for select in dialog

[sfc-gh-alisowski]

I was experiencing a bug where:

• a select with maxHeight set on it rendered in a dialog
• if the select has lots of options it would always flip, no matter the available space

I traced the code to here where it disregards the userSetMaxHeight when determining if needed to flip

Closes

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Snowflake

[snowystinger]

Thanks for the PR. The change looks right, but can you provide a reproduction so we can verify the fix? a storybook story is fine
I attempted to see if it fixed #7897 or #7960 to no avail unfortunately.

[sfc-gh-alisowski]

Will do. I'm about to go on a 2 week vacation but will def look when I'm back

[snowystinger]

I tired to reproduce this in

react-spectrum/packages/react-aria-components/stories/Modal.stories.tsx

Line 51 in 38a7696

<Dialog>

with no luck

[sfc-gh-alisowski]

Sorry it took me so long but here is a repro!

https://stackblitz.com/edit/vitejs-vite-m7yj7gpt?file=src%2FApp.tsx,src%2Fmain.tsx

[sfc-gh-alisowski]

In your example you aren't using maxHeight so you aren't hitting the bug

[sfc-gh-alisowski]

I checked the nightly and #8848 fixed the issue 🚀