-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add support for tree sections #9013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yihuiliao
wants to merge
21
commits into
main
Choose a base branch
from
tree-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
473d209
initial tree stuff
yihuiliao e896397
fix virtualized tree section expanding, update methods to remove flat…
yihuiliao c3385c1
cleanup
yihuiliao fb17656
more cleanup
yihuiliao a1c8b17
Merge branch 'main' into tree-section
yihuiliao 89df42f
update key after if its content node
yihuiliao 8491826
fix types when checking content node
yihuiliao 6f78fe7
fix spacing
yihuiliao 43f2895
update dynamic story
yihuiliao 99d4169
update setSize with added getDirectChildren function
yihuiliao 049f2a5
fix types, update at method
yihuiliao fce9dce
remove console logs
yihuiliao f138f6a
add collection dependency to gridlist
yihuiliao 900d69e
fix lint
yihuiliao ae36ec5
update yarn lock
yihuiliao cff1b4c
rename dynamic row section array
yihuiliao e6752ca
add tests, fix setSize for top level nodes inside a section
yihuiliao fb703b2
fix lint
yihuiliao 98289ce
remove comments
yihuiliao ed55388
more cleanup
yihuiliao 3facc4a
comments and stuff
yihuiliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we used to use the
getChildren
method fromTreeCollection
but now that we've changed it to get ALL the descendants of a parent node instead of its immediate descendants, we can't use that anymore. i decided to make a new function calledgetDirectChildren
which is essentially the same code as whatgetChildren
was before