Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: constraints added to linting #3533

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Jan 31, 2025

Description

Remove the bumpVersionsWithWorkspaceProtocolOnly setting from the Changeset config and downgrade the updateInternalDependencies from minor to patch to ensure local dependencies stay tightly aligned.

Restructure the constraints file a bit to make it more readable and ensure it is fully documented.

Apply the constraints via lint-staged whenever a package.json file is updated.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • yarn constraints: expect no changes to this because no functionality has changed. Should not get any console feedback because there are no suggested changes to the project.

Note: We'll have to validate the changeset update during the next release. We'll expect the next release to bump local devDependencies for all packages.

To-do list

  • I have read the contribution guidelines.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 13aae1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2025

🚀 Deployed on https://pr-3533--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Jan 31, 2025

File metrics

Summary

Total size: 3.25 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the build-constraints-linting branch from e1b903d to 5dee0cf Compare February 1, 2025 19:47
@castastrophe castastrophe force-pushed the build-constraints-linting branch from 5dee0cf to 13aae1d Compare February 1, 2025 19:47
@castastrophe castastrophe marked this pull request as ready for review February 1, 2025 19:47
@castastrophe castastrophe self-assigned this Feb 1, 2025
@castastrophe castastrophe added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. build Issues associated with the build process; often a refactor skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review low priority Not a critical update or fix; can be deprioritized if necessary labels Feb 1, 2025
@castastrophe castastrophe requested a review from pfulton February 1, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues associated with the build process; often a refactor low priority Not a critical update or fix; can be deprioritized if necessary ready-for-review size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant