feat(contextual-help): S2 migration #3909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdransf
added
size-5 L
🦋 Changeset detectedLatest commit: 75a08f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-3909--spectrum-css.netlify.app |
File metricsSummaryTotal size: 1.42 MB*
contextualhelp
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
cdransf
force-pushed
the
cdransf/s2-migration-contextual-help
branch
from
3bdff09 to
1850227
Compare
cdransf
changed the title
cdransf
force-pushed
the
cdransf/s2-migration-contextual-help
branch
from
de08037 to
57323f8
Compare
cdransf
force-pushed
the
cdransf/s2-migration-contextual-help
branch
from
c56c432 to
f237622
Compare
cdransf
requested review from
castastrophe,
rise-erpelding,
marissahuysentruyt and
aramos-adobe
cdransf
added
ready-for-review
and removed
wip
cdransf
force-pushed
the
cdransf/s2-migration-contextual-help
branch
from
f237622 to
40e2b6b
Compare
castastrophe
approved these changes
Jun 11, 2025
Comment on lines
+22
to
+27
| --spectrum-contextual-help-body-sans-serif-font-family: var(--spectrum-sans-font-family-stack); | ||
| --spectrum-contextual-help-body-sans-serif-font-weight: var(--spectrum-body-sans-serif-font-weight); | ||
| --spectrum-contextual-help-body-sans-serif-font-style: var(--spectrum-body-sans-serif-font-style); | ||
| --spectrum-contextual-help-body-line-height: var(--spectrum-line-height-200); | ||
|
|
||
| --spectrum-contextual-help-body-color: var(--spectrum-body-color); |
There was a problem hiding this comment.
That's so funny this ties right into our conversation this morning in backlog grooming! I think this makes a lot of sense here for now but I am interested in exploring more how typography can inherit better from the cascade without requiring so much intervention.
There was a problem hiding this comment.
Agreed — it struck me as being quite verbose. I'd love something simpler. ✨
cdransf
force-pushed
the
cdransf/s2-migration-contextual-help
branch
from
40e2b6b to
347868e
Compare
cdransf
force-pushed
the
cdransf/s2-migration-contextual-help
branch
from
1bceda1 to
75a08f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSS-819S2 migration for contextual help
This migrates the
contextual helpcomponent to the latest Spectrum 2 designs. Custom properties have been remapped and added per the design specification.Typographic and color tokens have been updated per design specifications.
All existing popover positioning varations are supported.
New custom properties
--spectrum-contextual-help-body-color--spectrum-contextual-help-body-line-height--spectrum-contextual-help-body-sans-serif-font-family--spectrum-contextual-help-body-sans-serif-font-style--spectrum-contextual-help-body-sans-serif-font-weight--spectrum-contextual-help-title-color--spectrum-contextual-help-title-font-style--spectrum-contextual-help-title-font-weight--spectrum-contextual-help-title-line-height--spectrum-contextual-help-title-sans-serif-font-familyNew mods
--mod-contextual-help-body-line-height--mod-contextual-help-body-sans-serif-font-family--mod-contextual-help-body-sans-serif-font-style--mod-contextual-help-body-sans-serif-font-weight--mod-contextual-help-body-size--mod-contextual-help-title-color--mod-contextual-help-title-font-style--mod-contextual-help-title-font-weight--mod-contextual-help-title-line-height--mod-contextual-help-title-sans-serif-font-family--highcontrast-contextual-help-heading-color--highcontrast-contextual-help-title-colorRemoved mods
--highcontrast-contextual-help-heading-colorScreenshots
To-do list