Skip to content

feat(slider): S2 migration, new precision variant, embedded textfield #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: spectrum-two
Choose a base branch
from

Conversation

aramos-adobe
Copy link
Contributor

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: af0af60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aramos-adobe aramos-adobe self-assigned this Jun 11, 2025
@aramos-adobe aramos-adobe marked this pull request as draft June 11, 2025 14:09
Copy link
Contributor

github-actions bot commented Jun 11, 2025

File metrics

Summary

Total size: 1.42 MB*
Total change (Δ): 🔴 ⬆ 1.54 KB (0.11%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Minified Gzipped Δ
slider 30.82 KB 29.10 KB 3.97 KB 🔴 ⬆ 1.34 KB

File change details

slider

Filename Head Minified Gzipped Compared to base
index.css 30.82 KB 29.10 KB 3.97 KB 🔴 ⬆ 1.34 KB
metadata.json 13.99 KB - - 🔴 ⬆ 1.17 KB

tokens

Filename Head Minified Gzipped Compared to base
css/dark-vars.css 46.16 KB - - -
css/global-vars.css 80.22 KB - - -
css/index.css 260.04 KB - - 🔴 ⬆ 0.79 KB
css/large-vars.css 44.56 KB - - 🔴 ⬆ 0.39 KB
css/light-vars.css 46.16 KB - - -
css/medium-vars.css 44.68 KB - - 🔴 ⬆ 0.39 KB
json/tokens.json 410.29 KB - - -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Jun 11, 2025

🚀 Deployed on https://pr-3945--spectrum-css.netlify.app

@aramos-adobe aramos-adobe changed the title Aramos-adobe/css1201-s2-slider-handle-variant feat(slider): S2 migration, new precision variant, embedded textfield Jun 12, 2025
@aramos-adobe aramos-adobe added size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete. S2 Spectrum 2 labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S2 Spectrum 2 size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant