Skip to content

test(alertbanner): updates alertbanner test file to restore text and action button label control functionality #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2025
Merged

test(alertbanner): updates alertbanner test file to restore text and action button label control functionality #3950

merged 3 commits into from
Jun 12, 2025
+2 −32

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Jun 11, 2025 •
edited
Loading

Description

CSS-1245

This removes an unnecessary test template that was overriding the Storybook controls for the alert text, action button label and semantic variants. Removing this template restores the functionality of all said controls and the previously displayed, fixed variants can be viewed using the controls or testing preview.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf self-assigned this Jun 11, 2025
@cdransf cdransf added wip This is a work in progress, don't judge. skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Jun 11, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 634d586

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025 •
edited
Loading

🚀 Deployed on https://pr-3950--spectrum-css.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025 •
edited
Loading

File metrics

Summary

Total size: 1.42 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

marissahuysentruyt
marissahuysentruyt reviewed Jun 11, 2025
View reviewed changes
@cdransf cdransf force-pushed the cdransf/alert-banner-control-fix branch from 880760d to c608031 Compare June 11, 2025 23:08
@cdransf cdransf marked this pull request as ready for review June 11, 2025 23:10
@cdransf cdransf force-pushed the cdransf/alert-banner-control-fix branch from c608031 to 78085d5 Compare June 12, 2025 02:05
marissahuysentruyt
marissahuysentruyt requested changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left small suggestions to polish it off- we can remove the changeset since we didn't change CSS, and a small deletion in the test file! Nice catch on this!

@cdransf cdransf added size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. ready-for-review and removed wip This is a work in progress, don't judge. labels Jun 12, 2025
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Jun 12, 2025
@castastrophe castastrophe changed the title fix(alertbanner): updates alertbanner test file to restore text and action button label control functionality test(alertbanner): updates alertbanner test file to restore text and action button label control functionality Jun 12, 2025
marissahuysentruyt
marissahuysentruyt approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@cdransf cdransf merged commit 7afe545 into spectrum-two Jun 12, 2025
30 of 34 checks passed
@cdransf cdransf deleted the cdransf/alert-banner-control-fix branch June 12, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

@marissahuysentruyt marissahuysentruyt marissahuysentruyt approved these changes

@rise-erpelding rise-erpelding Awaiting requested review from rise-erpelding

@aramos-adobe aramos-adobe Awaiting requested review from aramos-adobe

Assignees

@cdransf cdransf

Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT size-3 M ~18-30hrs; moderate effort or complexity, several work days needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdransf @castastrophe @marissahuysentruyt