Skip to content

Conversation

@castastrophe
Copy link
Collaborator

Description

This update removes --mod-assetcard-* custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.

  • Remove all --mod-assetcard-* custom property hooks.
  • Reduces unnecessary re-mapping of custom properties in favor of using them directly

Breaking change: the --mod-assetcard-* override layer is removed. Consumers should set --spectrum-assetcard-* variables directly where customization as needed.

Related issue(s)

  • fixes SWC-1264

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes (or confirmed existing coverage is sufficient for styling-only changes).
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a GitHub Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are passing or approved

Validation steps

  • No visual or behavioral changes compared to the current spectrum-two baseline.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:

    • The pages render correctly, are accessible, and are responsive.
  2. If components have been modified, VRTs have been run on this branch:

    • VRTs have been run and looked at.
    • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 15a1637

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 6 packages
Name Type
@spectrum-css/alertdialog Major
@spectrum-css/asset Major
@spectrum-css/assetcard Major
@spectrum-css/well Major
@spectrum-css/bundle Patch
@spectrum-css/preview Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe self-assigned this Oct 17, 2025
@castastrophe castastrophe added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2 labels Oct 17, 2025
@castastrophe castastrophe force-pushed the castastrophe/feat-assetcard-modifier-removal branch from 65ca92a to 4e57f0d Compare October 17, 2025 20:08
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

📚 Branch preview

PR #4258 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4258/index.html.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

File metrics

Summary

Total size: 1.42 MB*

Package Size Minified Gzipped
assetcard 8.39 KB 7.83 KB 1.69 KB

assetcard

Filename Head Minified Gzipped Compared to base
index.css 8.39 KB 7.83 KB 1.69 KB 🟢 ⬇ 7.44 KB
metadata.json 4.38 KB - - 🟢 ⬇ 4.51 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the castastrophe/feat-assetcard-modifier-removal branch 2 times, most recently from 109a27e to 87eb756 Compare October 17, 2025 20:31
@castastrophe castastrophe force-pushed the castastrophe/feat-assetcard-modifier-removal branch 7 times, most recently from 0a409a1 to 9d81e63 Compare October 22, 2025 15:55
Copy link
Member

@cdransf cdransf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✨

@castastrophe castastrophe force-pushed the castastrophe/feat-assetcard-modifier-removal branch from 9d81e63 to 5a73ada Compare October 22, 2025 16:05
@castastrophe castastrophe enabled auto-merge (squash) October 22, 2025 16:05
@rise-erpelding rise-erpelding self-requested a review October 22, 2025 16:36
@castastrophe castastrophe force-pushed the castastrophe/feat-assetcard-modifier-removal branch from 5a73ada to 15a1637 Compare October 22, 2025 16:40
@castastrophe castastrophe merged commit d1fd3cd into spectrum-two Oct 22, 2025
13 checks passed
@castastrophe castastrophe deleted the castastrophe/feat-assetcard-modifier-removal branch October 22, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2 size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants