- 
                Notifications
    You must be signed in to change notification settings 
- Fork 207
feat(assetcard): remove modifiers from the API [SWC-1264] #4258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(assetcard): remove modifiers from the API [SWC-1264] #4258
Conversation
| 
 | 
| Name | Type | 
|---|---|
| @spectrum-css/alertdialog | Major | 
| @spectrum-css/asset | Major | 
| @spectrum-css/assetcard | Major | 
| @spectrum-css/well | Major | 
| @spectrum-css/bundle | Patch | 
| @spectrum-css/preview | Patch | 
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
65ca92a    to
    4e57f0d      
    Compare
  
    | 📚 Branch previewPR #4258 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4258/index.html. | 
| File metricsSummaryTotal size: 1.42 MB* 
 assetcard
 * An ASCII character in UTF-8 is 8 bits or 1 byte. | 
109a27e    to
    87eb756      
    Compare
  
    3b337cc    to
    dcae9ef      
    Compare
  
    0a409a1    to
    9d81e63      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ✨
9d81e63    to
    5a73ada      
    Compare
  
    5a73ada    to
    15a1637      
    Compare
  
    
Description
This update removes
--mod-assetcard-*custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.--mod-assetcard-*custom property hooks.Breaking change: the
--mod-assetcard-*override layer is removed. Consumers should set--spectrum-assetcard-*variables directly where customization as needed.Related issue(s)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesValidation steps
spectrum-twobaseline.Regression testing
Validate:
The documentation pages for at least two other components are still loading, including:
If components have been modified, VRTs have been run on this branch: