Skip to content

fix(card): add border radius to slotted content to match parent card #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
Merged

fix(card): add border radius to slotted content to match parent card #5796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e40f17
fix(card): add border radius to slotted content to match parent card
cdransf Oct 8, 2025
1bd7e99
fix(card): scope border-radius change to small quiet only
cdransf Oct 13, 2025
c467d85
chore(card): update golden hash
cdransf Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ parameters:
# 3. Commit this change to the PR branch where the changes exist.
current_golden_images_hash:
type: string
default: fb61509de41ae6a2cd09fbcf661e20b9f270450b
default: 1bd7e9973de8f318233aa41b5b8a97a2956cd44d
wireit_cache_name:
type: string
default: wireit
Expand Down
23 changes: 8 additions & 15 deletions packages/card/src/card.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ slot[name="description"] {
height: 100%;
}

:host([variant="quiet"][size="s"]) #preview ::slotted(*) {
border-radius: calc(var(--spectrum-card-corner-radius) - var(--spectrum-focus-indicator-thickness));
}

:host([horizontal]) #preview {
width: auto;
}
Expand Down Expand Up @@ -97,23 +101,12 @@ sp-popover {
pointer-events: none;
}

:host([variant='quiet']:focus) #preview:after {
border: var(
--mod-card-focus-indicator-width,
var(--spectrum-card-focus-indicator-width)
)
solid
var(
--mod-card-focus-indicator-color,
var(--spectrum-card-focus-indicator-color)
);
:host([variant="quiet"]:focus) #preview:after {
border: var(--mod-card-focus-indicator-width, var(--spectrum-card-focus-indicator-width)) solid var(--mod-card-focus-indicator-color, var(--spectrum-card-focus-indicator-color));
}

:host([variant='quiet'][selected]:focus) #preview {
border-width: var(
--mod-card-focus-indicator-width,
var(--spectrum-card-focus-indicator-width)
);
:host([variant="quiet"][selected]:focus) #preview {
border-width: var(--mod-card-focus-indicator-width, var(--spectrum-card-focus-indicator-width));
}

/* This ensures that the checkbox is tabbable when the card toggles but is not itself focusable */
Expand Down
Loading