This repository was archived by the owner on Sep 27, 2021. It is now read-only.
fix(Connection): switched topic with no subscriptions exception to a debug message #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debug message replaced the error inside makeEventPacket to a debug message as this was blocking broadcasts from being sent when a socket connection was closed adonisjs#63
fixed tests relating to the makeEventPacket change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I've replaced the error inside Connection.makeEventPacket to a debug message as this was blocking broadcasts from being sent when a socket connection was closed. As far as I can tell, this does not cause any breaking changes.
Types of changes
What types of changes does your code introduce?
Checklist
Further comments
This solution is based off of the investigation here: #63 (comment)
Fixes #63