Set err only when an error occurs.
#30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version works, but is confusing. In the event that no error results from `f.Close()` and no error resulted during `io.Copy`, it'd set `err` to `nil` (but `err` was already `nil`). The suggested update removes the cause for my confusion and only sets `err` with the error from `f.Close()` in the event that an error actually occurred from that statement, and leaves in place the consideration that no error had occurred from `io.Copy` as well.
Set `err` only if an error occurred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was confusing because it sets
erreven whencloseErrisnil. The PR suggests a modification to clarify the behavior. Alternatively, perhaps adding a comment would be sufficient.