use explicit observers

adopted-ember-addons · Jun 6, 2015 · f3fb1c9 · f3fb1c9
1 parent 8198964
commit f3fb1c9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/addon/components/ember-chart.js b/addon/components/ember-chart.js
@@ -20,6 +20,8 @@ export default Ember.Component.extend({
     }
 
     this.set('chart', chart);
+    this.addObserver('data.[]', this.updateChart);
+    this.addObserver('options', this.updateChart);
   },
 
   willDestroyElement: function(){
@@ -28,9 +30,11 @@ export default Ember.Component.extend({
     }
 
     this.get('chart').destroy();
+    this.removeObserver('data.[]', this.updateChart);
+    this.removeObserver('options', this.updateChart);
   },
 
-  updateChart: Ember.observer('data', 'data.[]', 'options', function(){
+  updateChart: function(){
     var chart = this.get('chart');
     var data = this.get('data');
     var redraw = ChartDataUpdater.create({
@@ -44,5 +48,5 @@ export default Ember.Component.extend({
     } else {
       chart.update();
     }
-  })
+  }
 });