Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] drop node support for < 10 #216

Merged
merged 2 commits into from
May 27, 2020

Conversation

gabrielcsapo
Copy link
Contributor

Motivation

Breaking up PR #215.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update engines in package.json as well?

@gabrielcsapo
Copy link
Contributor Author

Updated the package.json @rwjblue

@rwjblue rwjblue merged commit d67e675 into adopted-ember-addons:master May 27, 2020
@gabrielcsapo gabrielcsapo deleted the node-10+-support branch May 27, 2020 21:23
@tniezurawski
Copy link

tniezurawski commented Sep 3, 2020

@gabrielcsapo @rwjblue Can we have a new release?

I'm not sure how v10.0.1 was published to npm repository but it's not in Releases on GH nor in tags in this repo 🤷‍♂️

Anyway, a few things are not released yet when comparing to the last tag: v10.0.0...master although dropping node < 10 is the major one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants