fix: @ember/test-helpers setResolver or setApplication

[MichalBryxi]

• Without this patch many tests fail for me with:

Promise rejected before "can access files": 
You must set up the ember-test-helpers environment 
with either `setResolver` or `setApplication` 
before running any tests.

• Fixes Problem with @ember/test-helpers>4.0.0 #1083
• Might need Regenerate lockfile for ember-inflector #1082 to be applied before this fix is useable

[MichalBryxi]

The weird thing is that setApplication is being called:

ember-file-upload/test-app/tests/test-helper.js

Line 4 in 5bc0e4a

import { setApplication } from '@ember/test-helpers';

[mkszepp]

I thinks this is not the correct fix...

With this change we don't test anymore test-helper v4, because it was changes in test-app.

The error occures only inside monorepos (it has no side effect in consumer apps)...

Possible fixes without downgrading in test-app:

• add pnpm i -f in ci.yml after build like we did in ember power select see https://github.com/cibernox/ember-power-select/blob/master/.github/workflows/ci.yml#L87
• split lock file by adding in .npmrc this shared-workspace-lockfile=false
• add test-helper in ember-try into overrides instead devDependencies

Btw: we should add in ember-try a test for test-helper v3... i think we have forget
Addon is atm tested only against v2 and v4

[MichalBryxi]

Ok, I actually have no idea what is happening here nor why. Just vague sense that all these steps make it tested via ember-try in correct way against correct versions.

I did not do the "we should add in ember-try a test for test-helper v3" as I could not infer what action should be taken there.

@mkszepp I just pushed the changes in a way I understood from your description. It-s highly likely it's completely wrong so would be really glad if you'd help me out here.

[mkszepp]

@MichalBryxi sry for my delay... i have tested locally to reproduce the issue... It looks like the pnpm-lock.yaml is not correct and you are running for this reason into this issue...

The only thing which you need to to is:

1. revert all changes which were done in PR (or start from master branch)
2. remove all node_modules folders
3. remove pnpm-lock.yaml
4. run pnpm install

After that you can run again your tests and everything should pass...

Edit:
I have seen you have also created a PR for that: #1082 this solves everything and this PR is not anymore needed

[gilest]

Thanks for the PR @MichalBryxi and thanks for your analysis @mkszepp

I will merge the lockfile regen PR. Hopefully this resolves the other local dev issues

Any idea how the lockfile got out of date? Perhaps I merged dependabot PRs too quickly...

[MichalBryxi]

Apologies, the PR #1082 only supported this issue, not fixed it. I am used to create PRs for individual fixes.

What I'm seeing on current master is still the same issue:

• https://gist.github.com/MichalBryxi/29639e65b823b968d42b0f63ac1cace3

Compare this to an improved situation on this branch:

• https://gist.github.com/MichalBryxi/d9f62075d6e6e9af09b30a41c625d11d

[mkszepp]

@MichalBryxi not sure whats going wrong... but here a PR with new lock file... #1089 this solve also your issue local... just try it out (i have in last days tested and regenerated and it was working fine, local and also testes in github should pass)

[mkszepp]

@gilest maybe you can merge my PR, when @MichalBryxi gives a positive feedback

[MichalBryxi]

Yay! 👍🏾 I can confirm that #1089 fixes this issue. Thank you!

[gilest]

Have done so. Thank you both for reporting, investigating and testing