Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test/demo app #477

Merged
merged 4 commits into from
May 16, 2024
Merged

Update test/demo app #477

merged 4 commits into from
May 16, 2024

Conversation

jahrock
Copy link
Contributor

@jahrock jahrock commented May 15, 2024

Solves #474

@jahrock jahrock force-pushed the chore-update-dummy-app branch from 9609a1d to f5a9db6 Compare May 15, 2024 17:38
@jahrock jahrock changed the title Chore update dummy app Update dummy app May 15, 2024
@mansona mansona changed the title Update dummy app Update test/demo app May 16, 2024
mansona
mansona approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I think we need to do a little bit of work to get the demo app publishing properly though 🤔 I'll look into that today

@mansona mansona merged commit caebaea into adopted-ember-addons:main May 16, 2024
14 checks passed
This was referenced May 16, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jahrock @mansona