[Bug]: prevent cyclical issues with normalizeObject (#99)

adopted-ember-addons · Jan 31, 2021 · e40da03 · e40da03
1 parent c753cb6
commit e40da03
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/utils/normalize-object.ts b/src/utils/normalize-object.ts
@@ -42,6 +42,11 @@ export default function normalizeObject<T extends { [key: string]: any }>(
       if (Object.prototype.hasOwnProperty.call(next, 'value') && next instanceof Change) {
         obj[key] = next.value;
       } else {
+        try {
+          JSON.stringify(next);
+        } catch (e) {
+          break;
+        }
         obj[key] = normalizeObject(next);
       }
     }

diff --git a/test/utils/normalize-object.test.ts b/test/utils/normalize-object.test.ts
@@ -36,4 +36,13 @@ describe('Unit | Utility | normalize object', () => {
 
     expect(value).toEqual({ details: { name: 'Ivan' } });
   });
+
+  it('it handles cyclical structures', () => {
+    let cyclical = { key: { cyclical: {}, name: 'not scoot' } };
+    cyclical.key = { cyclical, name: 'scoot' };
+    let obj = { cyclical };
+    const value = normalizeObject(obj);
+
+    expect(value.cyclical.key.name).toEqual('scoot');
+  });
 });