Fix inconsistency of the data returned by the API

[xavierfacq]

This PR is to resolve (partially) this issue adoptium/dash.adoptium.net#385
There is some inconsistency in data returned by the API.

Two endpoints do not return same data because they do not filter values in the same way.

Filter is .filter { it.release_type == ReleaseType.ga }

line 67 getTotalDownloadStats()
⚠️ do not have the filter

and

line 93 getTotalDownloadStatsForTag()
✔️ have a filter

➡️ I have added the filter to both function. Maybe I should remove the filter from the second, let me know.

Checklist

• You added tests to cover the change
• mvn clean install build and test completes
• You changed or added to the documentation

[xavierfacq]

Note that this PR will not fix the difference of counts returned by https://api.adoptium.net/v3/stats/downloads/total/
It will be in another PR.

[karianna]

code change looks OK but @johnoliver to check on the semantics here

[xavierfacq]

@johnoliver Note that I have found that in the following method, data are NOT filtered to compute the Total.
We can talk about that on Slack when your are available.

In GitHubDownloadStatsCalculator, line 55

return repos .repos .values .map { featureRelease -> val total = featureRelease .releases .getReleases() .filter { it.vendor == Vendor.getDefault() } .sumOf { it.download_count.toInt() }

[xavierfacq]

We chose to add as a parameter the list of types we want to include releaseTypes: List<ReleaseType>? . By leaving the filter on “ga” by default as before.

To fix the related issue (adoptium/dash.adoptium.net#385), we have to modify calls from the dashboard to retrieve all releaseTypes to compute drilldowns.

In api.tsx:
https://api.adoptium.net/v3/stats/downloads/total/${jdkVersion}?release_types=ga&release_types=ea