Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for default first broker login flow on realm level #1166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maximilian-krauss
Copy link

What this PR does / why we need it:

This PR adds support for a custom default first broker login flow defined on realm level:

realm: myRealm
firstBrokerLoginFlow: 'my-first-broker-login'
# ...

authenticationFlows:
- alias: my-first-broker-login
        providerId: basic-flow
        topLevel: true
        builtIn: false
        authenticationExecutions:
          - authenticatorFlow: true
            requirement: REQUIRED
            priority: 20
            autheticatorFlow: true
            flowAlias: my-first-broker-login User creation or linking
            userSetupAllowed: false
# ...

Without these changes the CLI was not able to import/update the firstBrokerLoginFlow because it was missing the special treatment like browserFlow or registrationFlow.

Special notes for your reviewer:

Have a nice day 🙂

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@maximilian-krauss maximilian-krauss force-pushed the feat/add-support-for-default-first-broker-login-flow branch 10 times, most recently from f549d97 to 79e3444 Compare October 22, 2024 11:45
@maximilian-krauss maximilian-krauss force-pushed the feat/add-support-for-default-first-broker-login-flow branch 2 times, most recently from 0519c05 to d1d55ed Compare November 7, 2024 11:41
# Conflicts:
#	.github/workflows/ci.yaml
#	CHANGELOG.md
#	pom.xml
@maximilian-krauss maximilian-krauss force-pushed the feat/add-support-for-default-first-broker-login-flow branch from d1d55ed to 285a7d1 Compare November 15, 2024 13:54
@maximilian-krauss maximilian-krauss force-pushed the feat/add-support-for-default-first-broker-login-flow branch from 285a7d1 to 311fc39 Compare November 15, 2024 14:07
Copy link

sonarcloud bot commented Nov 15, 2024

Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @maximilian-krauss
i tested the corresponding modifications with a custom authentication flow configuration , and the test case seems to be successful locally, but the workflow build for version 23.0.7 have some test failures, please can you look into it

Errors: 
[ERROR]   ImportParallelImportIT.shouldCreateRealm:51->AbstractImportTest.doImport:69->AbstractImportTest.doImport:76 » ImportProcessing de.adorsys.keycloak.config.exception.ImportProcessingException: Cannot find created group 'group10' in realm 'realmWithParallelImport'
[ERROR]   ImportParallelImportIT.shouldUpdateRealm:59->AbstractImportTest.doImport:69->AbstractImportTest.doImport:76 » WebApplication HTTP 500 Internal Server Error
[INFO] 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants