Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2FA #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ShadowKyogre
Copy link

So, here's my initial draft of integrating 2FA support into PageProtector. So far it works. Embeds form when appropriate, doesn't render page if the 2FA couldn't start, etc. But I'm still a bit confused at how to check if a 2FA flow is active without loading the entire Tfa class instance before the user signs in (regardless if anonymous or not). I haven't figured out a way around that, which is why there's still usage of this snippet for the second of the 2FA phase.

$tfa = $this->wire('modules')->get('ProcessLogin')->getTfa();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant