don't run sync dependencies in threads by default (#109)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "xpresso"
-version = "0.42.4"
+version = "0.43.0"
 description = "A developer centric, performant Python web framework"
 authors = ["Adrian Garcia Badaracco <[email protected]>"]
 readme = "README.md"

xpresso/_utils/endpoint_dependant.py

@@ -3,6 +3,7 @@
 import typing
 
 from di.api.providers import CallableProvider, CoroutineProvider
+from di.concurrency import as_async
 from di.dependant import Dependant
 
 from xpresso.dependencies._dependencies import Depends, DependsMarker
@@ -16,12 +17,13 @@ def __init__(
         endpoint: Endpoint,
         sync_to_thread: bool = False,
     ) -> None:
+        if sync_to_thread:
+            endpoint = as_async(endpoint)
         super().__init__(
             call=endpoint,
             scope="endpoint",
             use_cache=False,
             wire=True,
-            sync_to_thread=sync_to_thread,
         )
 
     def get_default_marker(self) -> DependsMarker[None]:

xpresso/_utils/overrides.py

@@ -39,7 +39,6 @@ def hook(
                 scope=scope,  # type: ignore[arg-type]
                 use_cache=dependant.use_cache,
                 wire=dependant.wire,
-                sync_to_thread=dependant.sync_to_thread,
             )
             if param is not None and param.annotation is not param.empty:
                 type_ = get_type(param)

xpresso/dependencies/_dependencies.py

@@ -69,24 +69,32 @@ def __init__(
         *,
         use_cache: bool = True,
         wire: bool = True,
-        sync_to_thread: bool = True,
+        sync_to_thread: bool = False,
         scope: typing.Optional[Scope] = None,
     ) -> None:
         super().__init__(
             call=call,
             scope=scope,
             use_cache=use_cache,
             wire=wire,
-            sync_to_thread=sync_to_thread,
         )
+        self.sync_to_thread = sync_to_thread
 
     def as_dependant(self) -> Dependant[DependencyType]:
+        call: "typing.Optional[DependencyProvider]"
+        if self.sync_to_thread:
+            if not self.call:
+                raise ValueError(
+                    "sync_to_thread can only be used if you explicitly declare the target function"
+                )
+            call = as_async(self.call)
+        else:
+            call = self.call
         return Dependant(
-            call=self.call,
+            call=call,  # type: ignore
             scope=self.scope,
             use_cache=self.use_cache,
             wire=self.wire,
-            sync_to_thread=self.sync_to_thread,
             marker=self,
         )
 

xpresso/routing/operation.py

@@ -101,7 +101,7 @@ def __init__(
             typing.Callable[[typing.Any], Response]
         ] = None,
         response_encoder: typing.Optional[Encoder] = JsonableEncoder(),
-        sync_to_thread: bool = True,
+        sync_to_thread: bool = False,
         # responses
         response_status_code: int = 200,
         response_media_type: str = "application/json",