-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom dependency scopes specified outside of Xpresso #97
base: main
Are you sure you want to change the base?
Conversation
@florimondmanca does this reflect your use case from #96? I think this works but is pretty unergonomic. There's a lot of footguns:
Any suggestions are welcome 😄 |
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 98.57% 98.56% -0.02%
==========================================
Files 126 126
Lines 4218 4248 +30
Branches 594 597 +3
==========================================
+ Hits 4158 4187 +29
- Misses 28 29 +1
Partials 32 32
|
@adriangb Hi! I must say I'm not sure I can make an informed comment on this, as I'm not sure I really understand Though, the example shown in the test looks like it would allow me to use type hints as a DI mechanism in the web part. But the fact that it induces coupling by requiring passing the scope everywhere we need the dependency does seem like a smell. I actually view things as two separate systems. In DDD terms, I've got my domain/application layer where I do DI with one container - be it with type hints or a |
No description provided.