Added nut_sides parameter to allow creation of non-cylinder nut #83
Conversation
|
Hi @linkian209 Thanks for your PR. Do I understand correctly that the nut_sides argument does exactly the same thing as the fn argument? |
It is the $fn argument specifically for the outer cyclinder. I wanted to make a hex nut and found that this was a fairly simple way to add this functionality to the library. |
adrianschlatter
force-pushed
the
develop
branch
from
59ebcb8 to
90ac0e2
Compare
|
Ok, I see. I have rebased your PR on top of the develop branch so that the PR does not re-introduce bugs I had already fixed. I‘m currently on a train, but when I find time I‘d like to test whether we can set the default value of nut_sides to something invalid. Otherwise, we cannot set nut_sides to 120 and fn to something else. Also, I want to test whether the change of order of the arguments will cause problems. |
* nut_sides must be last argument * default value = 0. With 120 as default, we cannot set nut_sides to 120 while simultaneously setting fn to something different from 120.
|
Ok, default value of 0 works for nut_sides. Also, we are not allowed to change the order of arguments for backwards compatibility reasons but it is ok to add a new argument at the end. I am going to merge this. Thanks for contributing to threadlib! |
Added a new parameter to the nut module that allows the creation of non cylinder nuts.
Would yield this:
