Recommended talks (#64)

* add a dedicated recommended talks using turbo frame

* restrict this route to turbo frame requests only

* remove @talks form talk#show

* add a basic test

* try to remove flaky

app/controllers/talks/recommendations_controller.rb

@@ -0,0 +1,15 @@
+class Talks::RecommendationsController < ApplicationController
+  skip_before_action :authenticate_user!
+  before_action :set_talk, only: %i[index]
+
+  def index
+    redirect_to talk_path(@talk) unless turbo_frame_request?
+    @talks = @talk.related_talks
+  end
+
+  private
+
+  def set_talk
+    @talk = Talk.find_by(slug: params[:talk_slug])
+  end
+end

app/controllers/talks_controller.rb

@@ -18,7 +18,6 @@ def index
   def show
     speaker_slug = params[:speaker_slug]
     @back_path = speaker_slug.present? ? speaker_path(speaker_slug, page: session[:talks_page]) : talks_path(page: session[:talks_page])
-    @talks = Talk.order("RANDOM()").excluding(@talk).limit(6)
     set_meta_tags(@talk)
   end
 

app/javascript/controllers/transition_controller.js

@@ -3,7 +3,7 @@ import { useTransition } from 'stimulus-use'
 
 export default class extends Controller {
   static values = {
-    enterActive: { type: String, default: 'transition ease-in duration-500' },
+    enterActive: { type: String, default: 'transition ease-in duration-300' },
     enterFrom: { type: String, default: 'transform opacity-0' },
     enterTo: { type: String, default: 'transform opacity-100' },
     leaveActive: { type: String, default: 'transition ease-in duration-300' },
@@ -36,7 +36,6 @@ export default class extends Controller {
 
     if (this.enterAfterValue >= 0) {
       setTimeout(() => {
-        console.log('enter')
         this.enter()
       }, this.enterAfterValue)
     }

app/models/talk.rb

@@ -95,4 +95,8 @@ def thumbnail_lg
   def thumbnail_xl
     self[:thumbnail_xl].presence || "https://i.ytimg.com/vi/#{video_id}/maxresdefault.jpg"
   end
+
+  def related_talks(limit: 6)
+    Talk.order("RANDOM()").excluding(self).limit(limit)
+  end
 end

app/views/talks/_card_horizontal.html.erb

@@ -1,5 +1,5 @@
 
-<div class="w-full items-center" id="<%= dom_id(talk, :card_horizontal) %>">
+<div class="w-full items-center" id="<%= dom_id(talk, :card_horizontal) %>" data-talk-horizontal-card>
 
   <%= link_to talk_path(talk),
         class: "flex aspect-video shrink-0 relative" do %>

app/views/talks/recommendations/index.html.erb

@@ -0,0 +1,5 @@
+<%= turbo_frame_tag "recommended_talks" do %>
+  <div data-turbo-temporary data-controller="transition" class="hidden" data-transition-enter-after-value="0">
+    <%= render partial: "talks/card_horizontal", collection: @talks, as: :talk, locals: {compact: true} %>
+  </div>
+<% end %>

app/views/talks/show.html.erb

@@ -16,7 +16,7 @@
         <% end %>
     </div>
     <div class="gap-4 w-60 flex-shrink-0 hidden md:flex md:flex-col px-4">
-      <%= render partial: "talks/card_horizontal", collection: @talks, as: :talk, locals: {compact: true} %>
+      <%= turbo_frame_tag "recommended_talks", target: "_top", src: talk_recommendations_path(@talk) %>
     </div>
   </div>
 </div>

config/routes.rb

@@ -31,7 +31,11 @@
       get :daily_visits
     end
   end
-  resources :talks, param: :slug, only: [:index, :show, :update, :edit]
+  resources :talks, param: :slug, only: [:index, :show, :update, :edit] do
+    scope module: :talks do
+      resources :recommendations, only: [:index]
+    end
+  end
   resources :speakers, param: :slug, only: [:index, :show, :update, :edit]
   resources :events, param: :slug, only: [:index, :show, :update, :edit]
   namespace :speakers do

test/controllers/talks/recommended_controller_test.rb

@@ -0,0 +1,19 @@
+require "test_helper"
+
+class Talks::RecommendationsControllerTest < ActionDispatch::IntegrationTest
+  def setup
+    @talk = talks(:one)
+  end
+
+  test "should get index with a turbo stream request" do
+    get talk_recommendations_url(@talk), headers: {"Turbo-Frame" => "true"}
+    assert_response :success
+    assert_equal assigns(:talk).id, @talk.id
+    assert_not_nil assigns(:talks)
+  end
+
+  test "a none turbo stream request should redirect to the talk" do
+    get talk_recommendations_url(@talk)
+    assert_redirected_to talk_url(@talk)
+  end
+end

test/system/speakers_test.rb

@@ -5,16 +5,12 @@ class SpeakersTest < ApplicationSystemTestCase
     @speaker = speakers(:one)
   end
 
-  # Contrary to "Talks", there is currently no "Speakers" heading
-  # test "visiting the index" do
-  #   visit speakers_url
-  #   assert_selector "h1", text: "Speakers"
-  # end
-
   test "should update Speaker" do
     visit speaker_url(@speaker)
     click_on "Edit", match: :first
 
+    assert_text "Editing speaker"
+
     fill_in "Bio", with: @speaker.bio
     fill_in "Github", with: @speaker.github
     fill_in "Name", with: @speaker.name

test/system/talks_test.rb

@@ -21,4 +21,11 @@ class TalksTest < ApplicationSystemTestCase
 
     assert_text "Your suggestion was successfully created and will be reviewed soon."
   end
+
+  test "renders some related talks" do
+    visit talk_url(@talk)
+
+    assert_selector "#recommended_talks"
+    assert_selector "[data-talk-horizontal-card]", count: [Talk.excluding(@talk).count, 6].min
+  end
 end