-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of RSS and Atom feeds #35
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,29 @@ | |||
require "test_helper" | |||
|
|||
class FeedControllerTest < ActionDispatch::IntegrationTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sorry about that I wanted to release the project ASAP and didn't clean all the test suites yet. #5
Someone is working on it
This looks awesome to me. I was wondering if we really need a feed route/controller vs using the existing talks_controller / route. The advantage I see using the talks_controller is we could use the filtering #3 once they are available. And provide a feed icon for every search result. So you could add to your feed Railsconf only by example. Not a big RSS user so not sure how people are using this |
@adrienpoly, kind of makes sense that we would move it to talks controller, I don't see any problems with that. The only concern that I would have I guess is that Only worry is here that we have a one entrypoint, though some formats would use |
@krapans sorry to bother you with that but I made an error trying to rebase the branch and deleted some codes. If you still have the branch locally can you open a new PR. Sorry about that ! |
@krapans ok I could recover the missing file. Test suite is green now will give it a final test before merge thanks |
Both feeds were validated by https://validator.w3.org/feed/. Can be down by using snapshots from tests as well.
RSS
Atom
Closes #12