Implementation of RSS and Atom feeds #35
Conversation
| @@ -0,0 +1,29 @@ | |||
| require "test_helper" | |||
|
|
|||
| class FeedControllerTest < ActionDispatch::IntegrationTest | |||
There was a problem hiding this comment.
Regarding the test suite, I made sure that these new tests passes and all is well, though on my local machine all test suite doesn't work, There are quite a few errors which seems to be not related to my changes even if I take in account fixtures.
Is this a known issue?
There was a problem hiding this comment.
yes sorry about that I wanted to release the project ASAP and didn't clean all the test suites yet. #5
Someone is working on it
|
This looks awesome to me. I was wondering if we really need a feed route/controller vs using the existing talks_controller / route. The advantage I see using the talks_controller is we could use the filtering #3 once they are available. And provide a feed icon for every search result. So you could add to your feed Railsconf only by example. Not a big RSS user so not sure how people are using this |
|
@adrienpoly, kind of makes sense that we would move it to talks controller, I don't see any problems with that. The only concern that I would have I guess is that Only worry is here that we have a one entrypoint, though some formats would use |
|
@krapans sorry to bother you with that but I made an error trying to rebase the branch and deleted some codes. If you still have the branch locally can you open a new PR. Sorry about that ! |
|
@krapans ok I could recover the missing file. Test suite is green now will give it a final test before merge thanks |
adrienpoly
force-pushed
the
main
branch
2 times, most recently
from
ca98c66
to
aa6f659
Compare
Both feeds were validated by https://validator.w3.org/feed/. Can be down by using snapshots from tests as well.
RSS
Atom
Closes #12