Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of RSS and Atom feeds #35

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

krapans
Copy link

@krapans krapans commented Jun 25, 2023

Both feeds were validated by https://validator.w3.org/feed/. Can be down by using snapshots from tests as well.

RSS

image

Atom

image

Closes #12

@krapans krapans changed the title Rss feed Implementation of RSS and Atom feeds Jun 25, 2023
@@ -0,0 +1,29 @@
require "test_helper"

class FeedControllerTest < ActionDispatch::IntegrationTest
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the test suite, I made sure that these new tests passes and all is well, though on my local machine all test suite doesn't work, There are quite a few errors which seems to be not related to my changes even if I take in account fixtures.

image image

Is this a known issue?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry about that I wanted to release the project ASAP and didn't clean all the test suites yet. #5
Someone is working on it

@krapans krapans marked this pull request as ready for review June 25, 2023 15:37
@adrienpoly
Copy link
Owner

This looks awesome to me. I was wondering if we really need a feed route/controller vs using the existing talks_controller / route.

The advantage I see using the talks_controller is we could use the filtering #3 once they are available. And provide a feed icon for every search result. So you could add to your feed Railsconf only by example.

Not a big RSS user so not sure how people are using this

@krapans
Copy link
Author

krapans commented Jun 25, 2023

@adrienpoly, kind of makes sense that we would move it to talks controller, I don't see any problems with that. The only concern that I would have I guess is that @pagy object would be ignored in case of RSS, because it kind of wouldn't fit in that structure.

Only worry is here that we have a one entrypoint, though some formats would use @pagy object and some like RSS/Atom wouldn't. Not sure though if its a dealbreaker.

@adrienpoly
Copy link
Owner

@krapans sorry to bother you with that but I made an error trying to rebase the branch and deleted some codes. If you still have the branch locally can you open a new PR. Sorry about that !

@adrienpoly
Copy link
Owner

@krapans ok I could recover the missing file. Test suite is green now will give it a final test before merge thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSS feed for all new videos
2 participants